Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it clear that git status is introduced in Episode 3 (issue #685) #686

Open
wants to merge 3 commits into
base: gh-pages
Choose a base branch
from

Conversation

@jdvorak001
Copy link

@jdvorak001 jdvorak001 commented Aug 14, 2019

I am suggesting this fix to issue #685.

jdvorak001 and others added 2 commits Aug 14, 2019
…pentry#685)

- actually teach the good practice of running ``git status`` before ``git init`` to avoid nested repositories
- be clear that ``git status`` is introduced in Episode 3, not 4
- show the contents of a .git sub-directory
- minor re-wordings in Episode 3
@munkm
Copy link
Member

@munkm munkm commented Jan 16, 2020

Hey @jdvorak001 thanks for the review request! I'm sorry it's taken a bit to get to your PR. I'll do my best to get to it this week!

Loading

Copy link
Contributor

@kekoziar kekoziar left a comment

I don't think that starting with explaining nested repositories is the best introduction to Git for new learners. It seems like they should first learn out to initialize a repository and what that means, then a little later have them do a thought experiment as to what should be made into repositories.

Loading

@jdvorak001
Copy link
Author

@jdvorak001 jdvorak001 commented Aug 2, 2021

Thanks for the review. It certainly is not the intent of this path to explain nested repositories, let alone promote them. It just warns against them (as does the currently released version). What I tried to plant is the good practice of running git status before git init. With that, the git status command is introduced a little.

Loading

Copy link
Contributor

@kekoziar kekoziar left a comment

This PR basically moves the "Places to Create Git Repositories" exercise into the lesson prior to learners first initializing a repository. I don't agree with the change because learners do not have the framework of initializing repositories on which to add the concept of nested repositories.

Loading


It is good practice to first check if this is a good place to do so:
a new repository shall not be nested in another repository placed higher up the directory hierarchy.
Copy link
Contributor

@kekoziar kekoziar Aug 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this sentence introduces topic of nested repositories. Learners will ask, "what does that mean" and "why shouldn't we do that" which is explained later in the lesson.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants