make lesson suitable for teaching with locally-built (serverless) pages #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
following this https://creativecommons.org/licenses/by/4.0/deed.es insead of usted tu
updated license
Update CONDUCT.md
Bring in latest changes to styles repository
updates sc/syllabus
Traducido
translate 'finish' to 'final
translate 'cite' to 'cita'
Update schedule.html
change finish for Final
translate overview and teaching
_config.yml: no 'mailto' in 'email'
Git for Windows doesn't provide fgrep, which is a shortcut to call `grep -F` on Mac and Linux. Instead, we have to use full arguments.
To avoid problems with various symbols, we have to specify the encoding when we read files. The actual codec name is `utf_8` but aliases like `utf8`, `utf-8`, etc are accepted. Here, I'm using `utf-8` alias. https://docs.python.org/3.8/library/codecs.html#standard-encodings This fixes `make lesson-check` when running under 'Git for Windows' for lessons that have non-cp1252 characters.
Co-authored-by: Maxim Belkin <maxim.belkin@gmail.com> Co-authored-by: François Michonneau <francois.michonneau@gmail.com>
Co-authored-by: Maxim Belkin <maxim.belkin@gmail.com>
When 'Website' action tests a lesson, it checks out repositories into the current working directory: 'lesson' directory doesn't exist. As a result, steps that use "lesson" as the working directory fail.
|
new & improved PR: now with corrected code block class tags |
|
This lesson currently builds on my system, as does the shell lesson. The MATLAB lesson doesn't following a PR that looks a lot like this one. I anticipate this PR being similar, given it also has a bazillion commits rather than the two commits on the shell lesson PR. I'm happy to look at this if someone will help with the Ruby/Jekyll side, but really there should be a separate PR for lesson template stuff, and for building locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Like we did in swcarpentry/shell-novice#1146, this PR makes the lesson suitable for building locally. It:
permalinkandlayoutfrom Extras and Setup pagesI built the site locally and everything seems to be working, but I'll run another check for broken links if and when this has been merged.