Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make lesson suitable for teaching with locally-built (serverless) pages #159

Open
wants to merge 256 commits into
base: gh-pages
Choose a base branch
from

Conversation

tobyhodges
Copy link
Member

Like we did in swcarpentry/shell-novice#1146, this PR makes the lesson suitable for building locally. It:

  • updates the lesson template
  • remove permalink and layout from Extras and Setup pages
  • updates internal links to the Reference page to keep them from breaking

I built the site locally and everything seems to be working, but I'll run another check for broken links if and when this has been merged.

ErinBecker and others added 30 commits Feb 5, 2018
Bring in latest changes to styles repository
translate 'finish' to 'final
translate overview and teaching
_config.yml: no 'mailto' in 'email'
maxim-belkin and others added 26 commits Aug 11, 2020
Git for Windows doesn't provide fgrep, which is a shortcut
to call `grep -F` on Mac and Linux. Instead, we have to use
full arguments.
To avoid problems with various symbols, we have to specify the encoding
when we read files.
The actual codec name is `utf_8` but aliases like `utf8`, `utf-8`, etc
are accepted. Here, I'm using `utf-8` alias.
https://docs.python.org/3.8/library/codecs.html#standard-encodings

This fixes `make lesson-check` when running under 'Git for Windows' for
lessons that have non-cp1252 characters.
Co-authored-by: Maxim Belkin <maxim.belkin@gmail.com>
Co-authored-by: François Michonneau <francois.michonneau@gmail.com>
Co-authored-by: Maxim Belkin <maxim.belkin@gmail.com>
When 'Website' action tests a lesson, it checks out repositories into the current working directory: 'lesson' directory doesn't exist.
As a result, steps that use "lesson" as the working directory fail.
… gh-pages"

This reverts commit 2c6b97e, reversing
changes made to 53e9913.
@tobyhodges tobyhodges requested a review from gcapes Oct 27, 2020
@tobyhodges
Copy link
Member Author

new & improved PR: now with corrected code block class tags 😁

@gcapes
Copy link
Contributor

gcapes commented Mar 2, 2021

This lesson currently builds on my system, as does the shell lesson. The MATLAB lesson doesn't following a PR that looks a lot like this one. I anticipate this PR being similar, given it also has a bazillion commits rather than the two commits on the shell lesson PR.

I'm happy to look at this if someone will help with the Ruby/Jekyll side, but really there should be a separate PR for lesson template stuff, and for building locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet