New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy 'checking our data' section from python lesson #152

Open
gcapes opened this Issue Jul 20, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@gcapes
Contributor

gcapes commented Jul 20, 2018

http://swcarpentry.github.io/python-novice-inflammation/05-cond/index.html#checking-our-data
http://swcarpentry.github.io/python-novice-inflammation/06-func/index.html#tidying-up

I like these as examples of using conditionals. Let's include them in the MATLAB lesson?

If time/space is a concern we could swap out the plot switch example?

@shwina

This comment has been minimized.

Member

shwina commented Jul 20, 2018

We did initially have that and I really didn't like it, for the following reasons:

  1. There is no explanation for why these features are "suspicious", and what we should do with that information. I'd imagine one would want to exclude that data from future analysis.

  2. Checking for the values at two points isn't enough to tell you whether a dataset is "suspicious", i.e., whether the value rises in a linear fashion.

  3. The values 0 and 20 are hard coded. This check won't catch any datasets where the maxima is the value 20.01, or 40 instead.

  4. One could only ever write checks like these from inspecting the data visually first. It also looks like there are multiple types of "defects" a dataset could have. This means that one would have to visually inspect all incoming data anyway for any new defects, making programmatic checks like this less useful than advertised.

Let me know if that makes sense.

@gcapes

This comment has been minimized.

Contributor

gcapes commented Jul 23, 2018

All good points!
Re: 1 - see #117

I do wonder whether we can still include something along these lines. It seems like a good starting point despite your justified concerns.

Perhaps we can revisit this after my current slew of PRs.

k8hertweck pushed a commit to k8hertweck/matlab-novice-inflammation that referenced this issue Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment