Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overall review of lesson 2016-06 by @valentina-s #287

valentina-s opened this issue Jul 15, 2016 · 2 comments

Overall review of lesson 2016-06 by @valentina-s #287

valentina-s opened this issue Jul 15, 2016 · 2 comments


Copy link

@valentina-s valentina-s commented Jul 15, 2016

  • [01-numpy] Typo in Data Type section: We can also find the out the type of the data contained in the NumPy array.
  • [01-numpy] Issue with sentence: 'More convenient when indices are computed rather than constant' - I don't understand the ending - seems unfinished.
  • [01-numpy] Multiple assignment - move it to later, maybe when discussing creating own functions
    maxval, minval, stdval = numpy.max(data), numpy.min(data), numpy.std(data)
  • [01-numpy] Change 'What if we need the maximum inflammation for all patients' to 'inflammation for each patient over all days'
  • [01-numpy] Typo in sentence: 'The mathematician Richard Hamming once said ... (or course) ...'
  • [01-numpy] Exercise – Drawing Straight Lines (Why are we expecting the lines to be straight?)
  • [02-loops] Explicitly say that the collections is the word = collection of characters.
  • [02-loops] Collection is not ordered - use sequence instead of collection.
  • [02-loops] Range does not produce a list in Python 3, so students cannot see the output of range.
  • [03-lists] State 'individual values and characters' in 'There is one important difference between lists and strings: we can change the values in a list, but we cannot change the characters in a string.'
  • [03-lists] Why not use Darwin instead of Bell?
  • [03-lists] Substitute equally with similarly in 'And equally, you can omit the ending index in the range to take a slice to the very end of the sequence'?
  • [03-lists] Some formatting issue before Tuples and Exchanges exercise
  • [03-lists] Tuples and Exchanges - since tuples have been removed, title should be changed, also I do not think the goal of the exercise is very clear, maybe relate to multiple assignment
  • [03-lists] Typo 'the the' in: If we want to start by analyzing just the first three files in alphabetical order, we can use the sorted built-in function to generate a new sorted list from the the glob.glob output.
  • [05-cond] Repetition of Tuples and exchanges: move or remove
  • [06-func] Type in: 'min, mean, and and max of centered data are'
  • [07-errors] Decide on what to do with the error python code.
  • [08-defensive] In Pre- and Post-Conditions Exercise change 'hers' to 'his/hers' in 'Compare your answer to your neighbor's: can you think of a function that will pass your tests but not hers or vice versa?'
  • [10-cmdline] Explain how to use the files - download, create during the session?

More Major Organizational Remarks:

  • [01-numpy] Start lessons with introducing simple variables? We now begin the lesson with loading the csv file into a numpy array (but we don't really use it), then introduce simple variables, then go back to working with the numpy array. I wonder if it would be better (especially for novices) to start with the simple variables first, and then continue with numpy.
  • [02-loops] What is the motivation for teaching loops before lists? I think the example of looping through the elements of a string confusing (and that is what I have heard form students) as a word is interpreted as a whole not as a collection of characters. I think the lesson order can be reversed.
Copy link

@gvwilson gvwilson commented Jul 15, 2016

Thanks very much for this - I'll mark it as "help wanted", and pull requests from anyone and everyone would be very welcome.

Copy link

@souravsingh souravsingh commented Sep 25, 2017

@valentina-s I am interested in fixing the issue in NumPy episode.

annefou added a commit that referenced this issue May 7, 2019
* explain string for #287

* changed explanation according to suggestion of @annefou
@ErinBecker ErinBecker added this to the June 2019 Release milestone May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants