Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision of Key points in python inflammation lesson #358

Open
stevehadd opened this issue Mar 6, 2017 · 3 comments
Open

Revision of Key points in python inflammation lesson #358

stevehadd opened this issue Mar 6, 2017 · 3 comments

Comments

@stevehadd
Copy link

@stevehadd stevehadd commented Mar 6, 2017

(This issue is part of my Software Carpentry Instructor training checkout)
The key points (KPs) in several sections of the Programming with Python (Inflamation data) lesson do not align with the content of the section.

  • 03: Storing Multiple Values in Lists
    • "Lists are indexed and sliced in the same way as strings and arrays." Learners will often use the keypoints as a "cheatsheet" to remind themselves of what they have learnt. It would be more useful to include an example of how to index and slice a list rather than refering them to another lesson.
    • This section mentions that lists can contain any python object, including lists. This is probably worth including as KP.
  • 05: Making Choices
    • "Nest loops to operate on multi-dimensional data." Not found in this section (or any section!), should be removed.
    • "Put code whose parameters change frequently in a function, then call it with different parameter values to customize its behavior." Not found in this section, should be removed as dealt with in section 6,
    • As the literals True and False are introduced here, they should be included as a KP.
  • 06: Creating Functions
    • "Define a function using def name(...params...)." Would be more useful when consulted by a learner if this look like a valid function definition e.g. 'def function_name(parameter1,parameter2)'
    • Call a function using name(...values...). Would be more useful when consulted by a learner if this look like a valid function call e.g. 'function_name(value1,value2)'
@stevehadd stevehadd changed the title Key points in python inflammation lesson not aligned with content Revision of Key points in python inflammation lesson Mar 6, 2017
rgaiacs pushed a commit to rgaiacs/swc-python-novice-inflammation that referenced this issue May 6, 2017
Changing discussion of stereotype threat
@valentina-s
Copy link
Contributor

@valentina-s valentina-s commented Oct 23, 2017

Thanks! It will be great if the key points get revised to reflect the content. PR's welcome!

yeemey added a commit to yeemey/python-novice-inflammation that referenced this issue Nov 1, 2017
@yeemey
Copy link
Contributor

@yeemey yeemey commented Nov 1, 2017

Hi, I opened a PR for this, addressing all the suggested changes except one re: True/False booleans in ep. 05. This appears in the challenges section, and instructors sometimes skip some of them. IMO, might not be necessary in Key Points, but I defer to @valentina-s. I'm happy to add that change if you think it's better.

@valentina-s
Copy link
Contributor

@valentina-s valentina-s commented Nov 20, 2017

Thanks! Looking now at the lesson there is no explicit statement really explaining that something like 1 > 0 returns the value True. I think it is worth adding a line about that. Then we can also add the keypoints.

valentina-s added a commit that referenced this issue Jan 18, 2018
Revised KPs in eps. 3, 5, 6 (Issue #358)
@ErinBecker ErinBecker added this to the June 2019 Release milestone May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.