New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up SVG figures #494

Open
maxim-belkin opened this Issue Apr 10, 2018 · 2 comments

Comments

Projects
3 participants
@maxim-belkin
Collaborator

maxim-belkin commented Apr 10, 2018

We have quite a few figures in our repository and they have to be easily maintainable. Therefore, we need to clean them up so that they:

  1. are minimal in size (don't have unnecessary information)
  2. are well formatted (using 2- or 4-space indentation)
<svg xmlns="http://www.w3.org/2000/svg" width="200" height="30">
  <text x="10" y="20" stroke="none" fill="red">
    print("SWC SVG FTW")
  </text>
</svg>
  1. don't use extra fonts
  2. don't use jargon

Please feel free to submit PRs and reference this issue.
Each such PR should modify one figure only (not all at once).

@akeshavan

This comment has been minimized.

akeshavan commented May 23, 2018

hi @maxim-belkin : I've cleaned up 1 file in this PR #537 -- let me know if you like the new format, and I can do the remaining images.

@maxim-belkin

This comment has been minimized.

Collaborator

maxim-belkin commented Jun 12, 2018

Example SVG:

<svg xmlns="http://www.w3.org/2000/svg" width="2500" height="1500">
 <defs>
    <style type="text/css"><![CDATA[
      .gray { fill: rgb(220,220,220); stroke-width:0; }
      .white { fill: none; stroke-width:2; stroke: #000; }
      .text { fill: #000; font-size: 60px; text-anchor: middle;  }
    ]]></style>
 </defs>
 <rect width="300" height="100" class="gray" />
 <rect width="300" height="100" y="150" class="gray" />
 <rect width="300" height="100" x="400" class="white" />
 <rect width="300" height="100" x="400" y="150" class="white" />
 <text x="150" y="70" class="text">final</text>
 <text x="150" y="220" class="text">original</text>
 <text x="550" y="70" class="text">0.0</text>
 <text x="550" y="220" class="text">32</text>
</svg>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment