Long lines in lessons #498
Comments
Shorten lines 8 and 24. See swcarpentry#498
Just for my own learning, why is it important to limit the lines to 100 characters? Is it about readability of the code? Are there other formatting conventions I should keep in mind? |
Also, please ignore #519. I forgot to delete my old fork before I started work on the new file. |
Why exactly 100? This number is more-or-less arbitrary. People usually choose the number of characters that fit in their text editor without wrapping to the next (virtual) line. "100" is hard-coded into lesson-check and, honestly, I don't care about its exact value as long as it is reasonable: not too small, not too large... it could be 78, 83, 94, etc.
Um... ok, but we need to talk :) You should use branches for pull requests:
|
Thanks for the explanation @maxim-belkin! Don't I need permission to access this repository in order to make branches? I'm working from the GitHub desktop client, so do I need to work in |
Um, to create branches in this repository one has to have proper permissions, but you don't need these.
To keep your fork up-to-date, you do:
Oh, and I now see that you've already deleted your fork that you used to submit #520. There is a better way! :) |
OK, I think I'm getting the hang of it now. I just did another PR (#521). Is that the right workflow? |
Yep! Just don't forget to switch back to
|
Hi @maxim-belkin , may be worth ticking off the lessons that have been done from the issue description at the top of this page, to make it clearer to newcomers which are left to do |
Thank you for the reminder, @MikeAllawayBham! |
Hi, I'd like to help with this. |
Hi, @katkoler. If you've got macOS or Linux, |
@maxim-belkin thanks! I'll just check that everything looks okay and open a pull request. |
Is there still any help needed? |
Hi Simon, |
Thank you Idko for putting me into the loop :) I will work on the other files in the coming days, that's it for today :) ... also if you have any comments on how to improve my PRs, I am happy to adjust them (especially in the future!) |
We need to shorten the following long lines in lessons (based on
make lesson-check-all
).Please feel free to submit PRs (please change one file per PR) and reference this issue (use
#498
).$ make lesson-check-all
/CONTRIBUTING.md: Line(s) too long: 3, 114, 126(Out of scope: has to be fixed in carpentries/style)Updated: January 20, 2021
The text was updated successfully, but these errors were encountered: