Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Episode 11 - command line, keypoints #764

Closed
k-dominik opened this issue Nov 26, 2019 · 5 comments · Fixed by #768
Closed

Episode 11 - command line, keypoints #764

k-dominik opened this issue Nov 26, 2019 · 5 comments · Fixed by #768

Comments

@k-dominik
Copy link
Contributor

@k-dominik k-dominik commented Nov 26, 2019

Dear swcarpentry team,

while I was going through the episdodes I stumbled over the last keypoint of the last episode (https://github.com/swcarpentry/python-novice-inflammation/blob/gh-pages/_episodes/11-cmdline.md)

In the end you mention sys.stdout as on of the keypoints. It is, however, not mentioned once in the text. I understand the urge to mention the counterpart of sys.stdin, but maybe it would be better to leave it out completely, or, preferrably explain it in the text.

Cheers!

@ldko

This comment has been minimized.

Copy link
Contributor

@ldko ldko commented Dec 2, 2019

@k-dominik thanks for catching that. I think it makes sense to remove the keypoint rather than trying to fit in an explanation/example in the episode at this point. What do you think @annefou @maxim-belkin ?

@annefou

This comment has been minimized.

Copy link
Contributor

@annefou annefou commented Dec 2, 2019

Definitely right! I would also remove it.

@maxim-belkin

This comment has been minimized.

Copy link
Contributor

@maxim-belkin maxim-belkin commented Dec 2, 2019

Agreed -- the keypoint has to go. It looks like it was never covered in the lesson (at least I couldn't find it).
Thank you, @k-dominik!

@ldko

This comment has been minimized.

Copy link
Contributor

@ldko ldko commented Dec 2, 2019

@k-dominik would you be willing to open a pull request to remove the keypoint?

k-dominik added a commit to k-dominik/python-novice-inflammation that referenced this issue Dec 3, 2019
@k-dominik

This comment has been minimized.

Copy link
Contributor Author

@k-dominik k-dominik commented Dec 3, 2019

thank you @ldko, @annefou, @maxim-belkin for your comments! I proceeded to open a PR (#768) that implements your consensus of removing the reference to stdout altogether.

@ldko ldko closed this in #768 Dec 3, 2019
ldko added a commit that referenced this issue Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.