Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First introduction of comments #867

Open
zerpiko opened this issue Sep 18, 2020 · 4 comments
Open

First introduction of comments #867

zerpiko opened this issue Sep 18, 2020 · 4 comments

Comments

@zerpiko
Copy link

zerpiko commented Sep 18, 2020

Hi.

I noticed that in lesson 2 (Analyzing Patient Data) the use of # to comment out text is explained with:

Everything in a line of code following the ‘#’ symbol is a comment that is ignored by Python. Comments allow programmers to leave explanatory notes for other programmers or their future selves.

after using a comment in an example. However, the first use of comments is in lesson 1 (Python Fundamentals)

# There are 2.2 pounds per kilogram
weight_lb = 2.2 * weight_kg
print(weight_kg_text, weight_kg, 'and in pounds:', weight_lb)

Wouldn't be better to move the explanation (and associated key point) to the first lesson?

@maxim-belkin
Copy link
Contributor

maxim-belkin commented Sep 18, 2020

Good catch, @zerpiko! I think we should do that.
Do you agree, @ldko and @annefou?

@ldko
Copy link
Contributor

ldko commented Sep 18, 2020

Yes, I think @zerpiko makes a good point. If Jose wants to open a PR to move the explanation, I think that would be great!

@annefou
Copy link

annefou commented Sep 18, 2020

Yes I agree,

@zerpiko
Copy link
Author

zerpiko commented Sep 21, 2020

Hi, thanks for the feedback. I created a PR for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants