Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lesson contribution: Alternate diagrams for lists of lists (variation on the pepper photos) #952

Open
kris-joseph opened this issue Aug 27, 2021 · 2 comments

Comments

@kris-joseph
Copy link
Contributor

kris-joseph commented Aug 27, 2021

The section on nested lists in the "Storing Multiple Values in Lists" episode makes reference to a grocery shelf, but the image presented is of a pepper packet in a pepper shaker and I find the mixed analogy difficult to follow as a learner.

I'd like to propose leaning more heavily on the grocery idea by providing images that illustrate the example. I've created a few graphics that I think could serve if implemented alongside some tweaking to the example and text:

A full nested-list object:
groceries_x

Dividing the nested list into rows:
groceries_x0

Addressing each "slot" on the grocery shelf:
groceries_x00_v2

It would replace the pepper image and add two more, but I think it might help learners understand the referencing a bit more clearly.

I'd be happy to put in a pull request and make the changes....?

@maxim-belkin
Copy link
Contributor

Thank you, @kris-joseph! I like these images a lot -- bright, colorful, clear. I also like the transparency level and colors you used for tags (light semitransparent gray background with white text). I guess we'd want to crop the images along the outer edges of top/bottom white lines and make positions of all tags consistent between the images.

Anyways, before you puts any more work into this, let us ask what other maintainers have to say about it.
CC @swcarpentry/python-novice-inflammation-maintainers

@ldko
Copy link
Contributor

ldko commented Aug 27, 2021

This visual explanation makes more sense to me than the pepper shaker/packets that are currently in the lesson, as I think the shaker with the single packet after seeing the shaker with multiple packets can be confusing with [x[0]]. I like how @kris-joseph is using the grocery shelf context like the text too. I vote for moving forward with this change. Thank you very much, @kris-joseph for proposing this and offering to implement changes and @maxim-belkin for the technical critique.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants