Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra path to illustrate eclusive nature of elif #413

Open
wants to merge 1 commit into
base: gh-pages
from

Conversation

@gjbex
Copy link
Contributor

@gjbex gjbex commented Oct 2, 2017

In the exercise "How Many Paths?" i've added an additional elif, and changed the answers accordingly. In this form, the exercise will test whether the learner realizes that elif are exclusive.

@tbekolay
Copy link
Contributor

@tbekolay tbekolay commented Oct 4, 2017

While I like testing the fact that if/elif/else blocks are mutually exclusive, I don't like how it is included in this exercise because no one would write a if/elif/else block like that. 4 > 5, 4 == 5, 4 < 5 are three nice, clean cases that one can easily reason about, but 4 > 5, 4 == 5, 4 < 5, 4 <= 5 has the feeling that one of these cases does not belong.

What do you think about, instead, adding a separate exercise right after this one that solely tests the exclusive nature of if/elif/else blocks?

@gjbex
Copy link
Contributor Author

@gjbex gjbex commented Oct 5, 2017

@maxim-belkin
Copy link
Contributor

@maxim-belkin maxim-belkin commented Apr 8, 2018

Hmm, I like this addition... What are your opinions, @annefou and @MikeTrizna ?

@annefou
Copy link
Contributor

@annefou annefou commented Apr 8, 2018

I like it too.

@maxim-belkin maxim-belkin force-pushed the swcarpentry:gh-pages branch from 4753644 to 90848ea Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants