Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing exercise with enumerate() to a simpler example. #533

Open
wants to merge 1 commit into
base: gh-pages
from
Open

Changing exercise with enumerate() to a simpler example. #533

wants to merge 1 commit into from

Conversation

@lwrubel
Copy link

@lwrubel lwrubel commented May 19, 2018

Addresses issue #378: "02-loop example should not suggest naive evaluation of polynomials".

Addresses issue #378: "02-loop example should not suggest naive
evaluation of polynomials".
@maxim-belkin
Copy link
Contributor

@maxim-belkin maxim-belkin commented May 19, 2018

Thanks, Laura. I like your changes (with a minor note that I'm not sure about using start=1 the first time enumerate is used... that is probably fine...).

Your exercise also highlights the importance of talking about lists first. There is a lists-loops branch that does that but I haven't had a chance to look into that switch more closely (need to verify that the logic of episodes does not break somewhere).

@lwrubel
Copy link
Author

@lwrubel lwrubel commented May 21, 2018

Thanks, yes, I think this would require that lists come before loops in the curriculum, should have caught that. FWIW, I totally support having lists before loops, because it makes it possible to have relevant and realistic exercises and challenges with loops.

@maxim-belkin
Copy link
Contributor

@maxim-belkin maxim-belkin commented Jun 14, 2018

I've added status:wait label to indicate that this issue depends on having episode on lists before the episode on for loops

@maxim-belkin maxim-belkin added this to Blocked in Lists-Loops Aug 14, 2018
@maxim-belkin maxim-belkin force-pushed the swcarpentry:gh-pages branch from 4753644 to 90848ea Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Lists-Loops
  
Blocked
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants