Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

03_lists.md: Add a "list index" figure and an example #554

Closed
wants to merge 1 commit into from

Conversation

pinpea
Copy link

@pinpea pinpea commented Jun 21, 2018

added fig/03-lists_oddsindex.svg
updated _episodes/03-lists.md to add figure
extended example in _episodes/03-lists.md to match figure

@maxim-belkin maxim-belkin self-assigned this Jun 21, 2018
@maxim-belkin maxim-belkin changed the title List index figure and example in 03_lists.md on new branch 03_lists.md: Add a "list index" figure and an example Jun 22, 2018
Copy link
Contributor

@maxim-belkin maxim-belkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, @pinpea!
Note that in the figure there is an incorrect result for odds[0:2] - it should be [1, 3], not [1, 3, 5]

~~~
{: .output}

![Values and their index in the list odds](../fig/03_lists_oddsindex.svg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the file you used is 03-lists_oddsindex.svg, not 03_lists_oddsindex.svg

The first, second and third value of odds: 1 3 5
~~~
{: .output}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add a tiny bit of prose before the figure saying something about visual representation of selecting elements in a list

@maxim-belkin maxim-belkin added status:changes requested Waiting for Contributor to update PR type:enhancement Propose enhancement to the lesson labels Aug 14, 2018
@maxim-belkin
Copy link
Contributor

maxim-belkin commented Oct 1, 2018

Gentle ping, @pinpea !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:changes requested Waiting for Contributor to update PR type:enhancement Propose enhancement to the lesson
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants