03_lists.md: Add a "list index" figure and an example #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxim-belkin
changed the title
maxim-belkin
suggested changes
Aug 13, 2018
There was a problem hiding this comment.
Thank you for the PR, @pinpea!
Note that in the figure there is an incorrect result for odds[0:2] - it should be [1, 3], not [1, 3, 5]
| ~~~ | ||
| {: .output} | ||
|
|
||
|  |
There was a problem hiding this comment.
The name of the file you used is 03-lists_oddsindex.svg, not 03_lists_oddsindex.svg
| The first, second and third value of odds: 1 3 5 | ||
| ~~~ | ||
| {: .output} | ||
|
|
There was a problem hiding this comment.
It would be nice to add a tiny bit of prose before the figure saying something about visual representation of selecting elements in a list
maxim-belkin
added
status:changes requested
|
Gentle ping, @pinpea ! |
maxim-belkin
force-pushed
the
gh-pages
branch
from
4753644
to
90848ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added fig/03-lists_oddsindex.svg
updated _episodes/03-lists.md to add figure
extended example in _episodes/03-lists.md to match figure