New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

03_lists.md: Add a "list index" figure and an example #554

Open
wants to merge 1 commit into
base: gh-pages
from

Conversation

Projects
None yet
2 participants
@pinpea

pinpea commented Jun 21, 2018

added fig/03-lists_oddsindex.svg
updated _episodes/03-lists.md to add figure
extended example in _episodes/03-lists.md to match figure

@maxim-belkin maxim-belkin self-assigned this Jun 21, 2018

@maxim-belkin maxim-belkin changed the title from List index figure and example in 03_lists.md on new branch to 03_lists.md: Add a "list index" figure and an example Jun 22, 2018

@maxim-belkin maxim-belkin force-pushed the pinpea:new-branch branch from 89d2581 to 52e8044 Jun 22, 2018

@maxim-belkin

Thank you for the PR, @pinpea!
Note that in the figure there is an incorrect result for odds[0:2] - it should be [1, 3], not [1, 3, 5]

~~~
{: .output}
![Values and their index in the list odds](../fig/03_lists_oddsindex.svg)

This comment has been minimized.

@maxim-belkin

maxim-belkin Aug 13, 2018

Collaborator

The name of the file you used is 03-lists_oddsindex.svg, not 03_lists_oddsindex.svg

The first, second and third value of odds: 1 3 5
~~~
{: .output}

This comment has been minimized.

@maxim-belkin

maxim-belkin Aug 13, 2018

Collaborator

It would be nice to add a tiny bit of prose before the figure saying something about visual representation of selecting elements in a list

@maxim-belkin

This comment has been minimized.

Collaborator

maxim-belkin commented Oct 1, 2018

Gentle ping, @pinpea !

@maxim-belkin maxim-belkin force-pushed the swcarpentry:gh-pages branch from 4753644 to 90848ea Oct 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment