Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list type under variables #659

Open
wants to merge 3 commits into
base: gh-pages
Choose a base branch
from
Open

Conversation

@sunray1
Copy link

@sunray1 sunray1 commented Jun 17, 2019

Arrays are used later in the lesson, but the idea that brackets equate to a list isn't explicitly described, it is implied.

sunray1 added 2 commits Jun 17, 2019
Arrays are used later in the lesson, but the idea that brackets equate to a list isn't explicitly described, it is implied.
Added list example under variables
@maxim-belkin
Copy link
Contributor

@maxim-belkin maxim-belkin commented Jun 17, 2019

Hi, @sunray1! Thank you for the pull request. Something went wrong with GitHub and it shows as if all lines have been changed. Could you please follow these instructions to see if submitting a pull request from a different branch helps or not.

@maxim-belkin
Copy link
Contributor

@maxim-belkin maxim-belkin commented Jul 31, 2019

Hey, Chandra!

I looked at the PR locally and the reason GitHub shows all lines as changed is because you used a text editor that converted all Linux-style line breaks to Windows-style line breaks (that is, converted LF (Line Feed) to CRLF (Carriage Return + Line Feed) characters). I fixed that in 05d2d05 but you should instruct you Git client to convert CRLF to LF upon committing changes with:

git config --global core.autocrlf true

I'll review changes suggested in this PR in a separate comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants