Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 06-func.md: visualize() vs analyze() #712

Open
wants to merge 3 commits into
base: gh-pages
from

Conversation

@davidbenncsiro
Copy link
Contributor

commented Aug 27, 2019

The function on line 152 could arguably be called visualize(). If such a change is made, other references to analyze() would need to be changed. Just a thought.

Update 06-func.md
The function on line 152 could arguably be called visualize(). If such a change is made, other references to analyze() would need to be changed. Just a thought.
@maxim-belkin

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2019

Thank you, David. I agree with this suggestion. In the lesson we say:

First, let's make an analyze function that generates our plots

calling it analyze is OK (we "analyze" data by looking at it), but not ideal (the function does visualization, not analysis). So, let's make this change -- please change all other occurrences of analyze to visualize (there are 4 places where we mention analyze function, all in 06-func.md).

Update 06-func.md
Replaced all occurrences of analyze() with visualize().
@davidbenncsiro

This comment has been minimized.

Copy link
Contributor Author

commented Sep 15, 2019

I've committed the 4 changes @maxim-belkin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.