Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify line color to blue #718

Open
wants to merge 1 commit into
base: gh-pages
from

Conversation

@nanjiangshu
Copy link

commented Sep 18, 2019

The plot generated by the original command might not be identical to the example images shown in the README and that may confuse the learners. I have added 'b' in the pyplot command to literally specify the line color to be blue so that the images generated by the command are identical to the example images in the README.

Please delete this line and the text below before submitting your contribution.


Thanks for contributing! If this contribution is for instructor training, please send an email to checkout@carpentries.org with a link to this contribution so we can record your progress. You’ve completed your contribution step for instructor checkout just by submitting this contribution.

Please keep in mind that lesson maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.


The plot generated by the original command might not be identical to the example images shown in the README and that may confuse the learners. I have added 'b' in the pyplot command to literally specify the line color to be blue so that the images generated by the command are identical to the example images in the README.
@maxim-belkin

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2019

Thank you for the PR, @nanjiangshu. Could you please describe the conditions under which the color of the line is not blue?

@nanjiangshu

This comment has been minimized.

Copy link
Author

commented Sep 18, 2019

Hi @maxim-belkin,

it is related to this issue #717
I got exactly the same color (pale blue) as rgaiacs when using the old command.

I guess it might be related to the version of Python or matplotlib. I used Python 3.7.1 and matplotlib 3.0.2 on Mac.

Best,

Nanjiang

@maxim-belkin

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2019

OK, so the color you get is blue.... just wanted to make sure!

The differences in the tones of blue is due to different Matplotlib versions (they changed the default colormap at some point).

I'm afraid I'm going to pass on this. Specifying colors is important when drawing multiple things in a single "axes". But it can be confusing for those new to Matlab-style plotting with Matplotlib.

  • "b" is for blue, "r" for red
  • oh, great! what about black lines?
  • oh, for black lines you have to use "k"
  • okaaaaay ...

@annefou, your thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.