Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved data description to lesson 2. #775

Open
wants to merge 5 commits into
base: gh-pages
Choose a base branch
from

Conversation

rraffiu
Copy link

@rraffiu rraffiu commented Jan 20, 2020

Based on my recent teaching experience of these lessons I think the data description is out of place. It should be in lesson two.

@maxim-belkin
Copy link
Contributor

@maxim-belkin maxim-belkin commented Jan 20, 2020

Thank you for your contribution, Rafi, and congratulations on your first pull request to our lesson.

We (maintainers of the lesson) discussed this at our previous meeting and I'm glad to see the first contribution related to the order of information in our lesson since "the big split" (the split of the first episode into three separate ones).

Anyways, here are my comments:

  1. You introduce a section called "Python" with only two sentences in it -- I don't think we need a section for two sentences.
  2. Portability is a questionable strength -- Python code relies on whitespaces and when these are not handled properly (e.g. when one does not use proper HTML tags), Python code breaks.
  3. Unless we explain what "interpreted" means, I'd say we don't need this qualifier. I like "general-purpose", but it would be great to support this statement with examples of areas where it is used.
  4. Suggested location for the ## Inflammation data section seems to interrupt the flow of (information in) the episode slightly.
  5. Addition of the Python section is not related to the move of the Inflammation data section, so I'd suggest we do these two operations in two separate pull requests.

Thanks again!

@rraffiu
Copy link
Author

@rraffiu rraffiu commented Jan 20, 2020

Thanks Maxim,

I have removed the python intro/section. And I am not a professional programming expert (rather a physicist who uses python to do his research) so I don't know the technically correct language. Here is what I feel as an instructor and python user:

  1. This lesson needs a few lines introducing python.
  2. A couple of line why is it so popular across disciplines (particularly non-specialists like myself).

I will try to come up with something along these lines in a separate commit and you can help me iron out any wrinkles.

Regarding the data description place. It may not be at the best place but it certainly is at a better place than before. This again is an instructors gut feeling.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants