New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear instructions for contributing to R lessons #304

Open
naupaka opened this Issue Aug 19, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@naupaka
Member

naupaka commented Aug 19, 2017

I can't seem to find a clear simple set of instructions on how to contribute to the R lessons. As I recall they used to be in contributing.md, but perhaps that was modified at some point so R-specific things (like only modify the Rmd files) are not there. This should be fixed.

@jcoliver

This comment has been minimized.

Collaborator

jcoliver commented Jan 12, 2018

The contributing.md seems to be restricted to Git/GitHub instructions. But if contributors are testing their code locally (like we all do, right? RIGHT?), and generate files that shouldn't be included in the PR (md or Rmd?), are there instructions for that? (I think this is what the OP is about, right @naupaka ?)

@naupaka

This comment has been minimized.

Member

naupaka commented Jan 13, 2018

Yeah I think the trick is that the contributing.md comes from the styles repo, which is across all lessons, and the R lessons have some particularities that are distinct. This will also be the case if/when python development shifts to jupyter notebooks from markdown.

@jcoliver

This comment has been minimized.

Collaborator

jcoliver commented Jan 30, 2018

A great visualization is available in #342 . Maybe we could add a START_HERE.md with information like this that is relatively repo-specific (for now)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment