New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in # of functions in text in 13: dplyr #331

Open
cmaimone opened this Issue Dec 5, 2017 · 5 comments

Comments

Projects
None yet
5 participants
@cmaimone

cmaimone commented Dec 5, 2017

Part 13: dplyr, says "we're going to cover 6 of the most commonly used functions..." and then only lists 5 functions. Either arrange should be added as the 6th, or the sentence should be edited to say 5 functions. I can make a PR, but I don't know whether arrange was intentionally excluded, or if this is just an omission.

@naupaka

This comment has been minimized.

Member

naupaka commented Jan 8, 2018

Thanks for catching that, and sorry for the delayed response. Seems like a typo. I think the easiest for now would be change 6 to 5. arrange() is handy, but not always used like most of the others, so perhaps we could get away without having it in there now. A PR to fix that would be welcome.

I think if anything, these lessons often err on the side of too much content, and could use more focus, so no reason to add more in here.

@cmaimone

This comment has been minimized.

cmaimone commented Jan 9, 2018

Do you want changes made to the Rmd or md file?

@naupaka

This comment has been minimized.

Member

naupaka commented Jan 10, 2018

Just the Rmd, please. I render those to md when we rebuild the site, so any changes to md will get overwritten. Thanks!

@anuj2054

This comment has been minimized.

anuj2054 commented Sep 21, 2018

Is there anything left in this issue ?

@naupaka

This comment has been minimized.

Member

naupaka commented Sep 21, 2018

Yes, this still needs fixed - I just checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment