New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use read_... functions rather than read.csv, read.table etc #442

Open
markdunning opened this Issue Oct 16, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@markdunning
Contributor

markdunning commented Oct 16, 2018

Hi,

It seems like read_csv, read_tsv et al are the tidyverse way of importing data frames, but in some of the lessons (ggplot2, dplyr in particular) read.csv is used. Perhaps time to switch to using read_csv?

@mawds

This comment has been minimized.

Collaborator

mawds commented Oct 17, 2018

Good comment; potentially this is quite a big change, if we move over to "pure" tidyverse throughout. @naupaka @jcoliver ; what are your thoughts?

FWIW I think we should at some point end up switching to a pure tidyverse approach, as it becomes more widely used. Whether that is now or not I'm less sure. Presumably a change of that size is something the curriculum advisory committee would want to take a view on?

@naupaka

This comment has been minimized.

Member

naupaka commented Oct 17, 2018

I agree this is a question for the advisory committee. Personally I would be inclined to switch all to base R's read.csv() for these lessons, as I am not sure of the benefit of read_csv() to the specific things we are covering. Not because the tidyverse isn't great, but advocating for dependencies right off the bat makes me a little nervous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment