Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to update contributing.md to reflect new master branch Travis system #488

Open
naupaka opened this issue Mar 25, 2019 · 5 comments

Comments

Projects
None yet
4 participants
@naupaka
Copy link
Member

commented Mar 25, 2019

Because the current version is now out of date. cc @mawds @jcoliver

@mawds

This comment has been minimized.

Copy link
Collaborator

commented Mar 25, 2019

Should this be an issue for the styles repository? That still shows gh-pages in its CONTRIBUTING.md

@naupaka

This comment has been minimized.

Copy link
Member Author

commented Mar 25, 2019

Good question. @fmichonneau @rgaiacs ?

@rgaiacs

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

@naupaka and @mawds Thanks for the issue. As far as I know, The Carpentries never make the migration to use master instead of gh-pages. This was because of the extra step in settings required to have the lesson built by GitHub Pages.

I believe that @fmichonneau was investigating ways to use Travis CI to make the build of the lesson but I'm not aware of progress on it. Sorry.

@fmichonneau

This comment has been minimized.

Copy link
Member

commented Mar 26, 2019

You can edit the file in your repository.

The CONTRIBUTING file in the styles is actually not part of the template that gets updated with new releases. It's only part of the files that populate the repo when first creating the lesson.

@naupaka

This comment has been minimized.

Copy link
Member Author

commented Mar 26, 2019

Thanks @fmichonneau. I can get to this in a couple days.

@naupaka naupaka self-assigned this Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.