Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to update contributing.md to reflect new master branch Travis system #488

Open
naupaka opened this issue Mar 25, 2019 · 9 comments
Open

Comments

@naupaka
Copy link
Member

@naupaka naupaka commented Mar 25, 2019

Because the current version is now out of date. cc @mawds @jcoliver

@mawds
Copy link
Contributor

@mawds mawds commented Mar 25, 2019

Should this be an issue for the styles repository? That still shows gh-pages in its CONTRIBUTING.md

@naupaka
Copy link
Member Author

@naupaka naupaka commented Mar 25, 2019

Good question. @fmichonneau @rgaiacs ?

@rgaiacs
Copy link
Contributor

@rgaiacs rgaiacs commented Mar 25, 2019

@naupaka and @mawds Thanks for the issue. As far as I know, The Carpentries never make the migration to use master instead of gh-pages. This was because of the extra step in settings required to have the lesson built by GitHub Pages.

I believe that @fmichonneau was investigating ways to use Travis CI to make the build of the lesson but I'm not aware of progress on it. Sorry.

@fmichonneau
Copy link
Member

@fmichonneau fmichonneau commented Mar 26, 2019

You can edit the file in your repository.

The CONTRIBUTING file in the styles is actually not part of the template that gets updated with new releases. It's only part of the files that populate the repo when first creating the lesson.

@naupaka
Copy link
Member Author

@naupaka naupaka commented Mar 26, 2019

Thanks @fmichonneau. I can get to this in a couple days.

@fjuniorr
Copy link
Contributor

@fjuniorr fjuniorr commented Jul 19, 2019

I've submitted PR #539 to fix this. However, for me, the confusion came from following the guide mentioned in the The Carpentries Handbook for novice contributors that instructs for the use of gh-pages as the main branch.

Not really sure in how to best clarify this.

@naupaka naupaka closed this in #539 Jul 19, 2019
@naupaka naupaka reopened this Jul 19, 2019
@naupaka
Copy link
Member Author

@naupaka naupaka commented Jul 19, 2019

I have reopened this to keep the thread, it seems like we need to deal with the Carpentries Handbook issue. @fmichonneau how would you like us to move forward on this? Can we just add some additional detail to the handbook?

@fmichonneau
Copy link
Member

@fmichonneau fmichonneau commented Jul 19, 2019

Can we just add some additional detail to the handbook?

That would be great if someone could do a PR to update the info on the handbook for R-based lessons.

@jcoliver
Copy link
Contributor

@jcoliver jcoliver commented Aug 28, 2019

Included language for editing Rmd files in #555, but CONTRIBUTING.md could still use attention regarding the master (as opposed to gh-pages) branch.

fmichonneau pushed a commit that referenced this issue Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

6 participants