Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent code styling #604

Open
mstrimas opened this issue Jan 13, 2020 · 1 comment
Open

Consistent code styling #604

mstrimas opened this issue Jan 13, 2020 · 1 comment

Comments

@mstrimas
Copy link
Contributor

@mstrimas mstrimas commented Jan 13, 2020

I see a lot of inconsistency in style of R code within the lessons. Mostly inconsistent use of spacing (e.g. sample(1:10, size=5) vs. sample(1:10, size = 5)), naming (var_name vs. varName), single vs. double quotes, etc. I find it distracting and feel like it doesn't encourage best practices, although I'm admittedly especially uptight about this stuff. If there's any interest, I'd be happy to run through all the lessons and submit a PR making them all conform to the Tidyverse style guide.

@jcoliver

This comment has been minimized.

Copy link
Contributor

@jcoliver jcoliver commented Jan 14, 2020

Thanks, @mstrimas . #548 and #589 deal with some of this. I'd suggest holding off for now until those two PRs finish review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.