Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canonicalize CRAN links #504

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@katrinleinweber
Copy link
Contributor

commented May 1, 2019

CRAN asks people to use this URL variant when linking to packages ;-) This PR results from a semi-automatic search-and-replace script and implements their suggestion.

@jcoliver

This comment has been minimized.

Copy link
Collaborator

commented May 1, 2019

Thanks @katrinleinweber ! Looks good. Will merge pending successful Travis CI build.

@jcoliver

This comment has been minimized.

Copy link
Collaborator

commented May 1, 2019

@katrinleinweber thanks again for this. Would you update the PR so only the .Rmd files (and not the .md) files are changed?

@katrinleinweber

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

Do the .md changes break Travis' build of gh-pages? Since they introduce the exact same changes as in the .Rmd files I assumed they would merge & build cleanly.

@jcoliver

This comment has been minimized.

Copy link
Collaborator

commented May 7, 2019

@katrinleinweber I think so, but I'll defer to @naupaka . What sort of issues do edited .md files cause during build?

@naupaka

This comment has been minimized.

Copy link
Member

commented May 7, 2019

Depends on the modification times because we rely on a makefile. Easiest to just delete the .md files so there's no possibility of it thinking it's already built, esp. given merging of other PRs, etc.

@katrinleinweber katrinleinweber force-pushed the katrinleinweber:canonicalize-cran-links branch from 9e8d68e to 9f74519 May 8, 2019

@katrinleinweber

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

I assumed that the modification times of all files become the timestamp of Travis cloning the git repo into its VM. Thus, the makefile would see the same timestamp for both .md & .Rmd files anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.