Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update links #551

Open
wants to merge 1 commit into
base: master
from

Conversation

@ldutoit
Copy link

commented Aug 13, 2019

The links were broken. I suggest a new link for "return" and remove the link for body as it was not working and I did think find it added much value. I started by looking for another link for body but I could not find one.

I suggest these changes as part of checkout

Please delete this line and the text below before submitting your contribution.


Thanks for contributing! If this contribution is for instructor training, please send an email to checkout@carpentries.org with a link to this contribution so we can record your progress. You’ve completed your contribution step for instructor checkout just by submitting this contribution.

Please keep in mind that lesson maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact Kate Hertweck (k8hertweck@gmail.com).


update links
The links were broken. I suggest a new link for "return" and remove the link for body as it was not working and I did think find it added much value. I started by looking for another link for body but I could not find one.

I suggest these changes as part of checkout
@jcoliver

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

Thanks for the PR, @ldutoit . Before we accept the changes, I want to double check with @naupaka about what those links were supposed to reference. The resources may still be in the repository, they just might have moved...

@naupaka

This comment has been minimized.

Copy link
Member

commented Aug 24, 2019

@jcoliver yes, good question. I think the links were supposed to be internal links to those sections, and they may be broken because of Jekyll changes or parsing script issues. I think we'd like to fix rather than change/delete them if possible.

@fmichonneau -- are those links the right way to link to internal sections with the current syntax?

e.g.

[body]({{ page.root }}/reference/#function-body)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.