Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell check and apply consistent code style (close #548) #589

Open
wants to merge 8 commits into
base: master
from

Conversation

@katrinleinweber
Copy link
Contributor

katrinleinweber commented Nov 20, 2019

This is an updated version of #548 as per its review. All thanks to @adamhsparks for doing most of the work. I just added a few additional clean-ups and resolved the merge conflicts that appeared since then.

@adamhsparks

This comment has been minimized.

Copy link
Contributor

adamhsparks commented Nov 20, 2019

Thanks for this. I've just simply not had time to go back and make the requested changes since I submitted the original PR.

@jcoliver

This comment has been minimized.

Copy link
Contributor

jcoliver commented Nov 25, 2019

Thanks @adamhsparks and @katrinleinweber, we are reviewing these changes.

@katrinleinweber

This comment has been minimized.

Copy link
Contributor Author

katrinleinweber commented Nov 26, 2019

I applied the changes of 3bca74b, but in order to keep it aligned with the above-taught labs(y = ...):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.