Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 04-data-structures-part1.Rmd #602

Merged
merged 1 commit into from Jan 14, 2020
Merged

Conversation

@mstrimas
Copy link
Contributor

mstrimas commented Jan 11, 2020

The file data/feline-data_v2.csv is referenced in text and used in the examples, but there is no link given to download the file. This commit adds a link to the file and download instructions. This addresses issue #572

I also find it odd that data/feline-data.csv is created via code at the top of this lessons. Seems like a waste of time typing that in. Why not have folks download this file as well? If there's interest I could add that to this commit or a new one.

The file `data/feline-data_v2.csv` is referenced in text and used in the examples, but there is no link given to download the file. This commit adds a link to the file and download instructions. This addresses issue #572
@mstrimas

This comment has been minimized.

Copy link
Contributor Author

mstrimas commented Jan 11, 2020

Oh, I see now from this issue and this PR that the intention is to actually remove this example using feline data v2 altogether, so this PR is obsolete. It's a bit confusing because this more recent issue suggests adding a download link, which is what I did.

@jcoliver jcoliver merged commit 768692c into swcarpentry:gh-pages Jan 14, 2020
@jcoliver

This comment has been minimized.

Copy link
Contributor

jcoliver commented Jan 14, 2020

Thanks, @mstrimas . I agree that feline data v2 may be deprecated in the future, but until that time, the link may be useful for some instructors.

@mstrimas mstrimas deleted the mstrimas:add-feline-data branch Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.