Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus 02-func-R.md#testing-and-documenting on most useful tests? #364

Open
katrinleinweber opened this issue Jun 12, 2018 · 1 comment · May be fixed by #496
Open

Focus 02-func-R.md#testing-and-documenting on most useful tests? #364

katrinleinweber opened this issue Jun 12, 2018 · 1 comment · May be fixed by #496

Comments

@katrinleinweber
Copy link
Contributor

@katrinleinweber katrinleinweber commented Jun 12, 2018

Follow-up to #361: https://github.com/swcarpentry/r-novice-inflammation/blob/d1773f4ae7e0dfae36c456e39a6647fd0baba986/_episodes/02-func-R.md#testing-and-documenting currently teaches all min, mean, max and sd to interactively test the center function. I'm confused by this number of tests TBH, and esp. explanation:

the original mean was about 1.75, so the lower bound from zero is now about -1.75. The mean of the centered data is 0.

and max is not refered to. I trust that it's mathematically correct, but only sd seems logical to me, which fits well to the "go further" part of the explanation.

Shall we remove the min and max tests, or should we maybe update the explanation with a back-reference to the center implementation:

the original mean was about 1.75. Because we the mean from all data, it seems correct that the lower bound shifted from 0 to now about -1.75. And that the mean of the centered data is now 0.

@katrinleinweber katrinleinweber changed the title Focus 02-func-R.md#testing-and-documenting on most useful tests Focus 02-func-R.md#testing-and-documenting on most useful tests? Jun 12, 2018
@diyadas
Copy link
Contributor

@diyadas diyadas commented Jun 12, 2018

You know my vote :)

In case anyone else is reading, I prefer mean and sd only - don't find much value in max and min here.

@ErinBecker ErinBecker added this to the June 2019 Release milestone May 9, 2019
aakrosh added a commit to aakrosh/r-novice-inflammation that referenced this issue Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants