Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

June 2019 Lesson Release checklist #415

Open
fmichonneau opened this issue Apr 16, 2019 · 5 comments

Comments

Projects
None yet
4 participants
@fmichonneau
Copy link
Member

commented Apr 16, 2019

If your Maintainer team has decided not to participate in the June 2019 lesson release, please close this issue.

To have this lesson included in the 18 June 2019 release, please confirm that the following items are true:

  • Example code chunks run as expected
  • Challenges / exercises run as expected => @katrinleinweber went through all non-supp
    lementary material
  • Challenge / exercise solutions are correct => #424 & #427
  • Call out boxes (exercises, discussions, tips, etc.) render correctly => @katrinleinweber checked for left-over >, {:, etc. in HTML & found none
  • A schedule appears on the lesson homepage (e.g. not “00:00”)
  • Each episode includes learning objectives
  • Each episode includes questions
  • Each episode includes key points
  • Setup instructions are up-to-date, correct, clear, and complete => 86a5148
  • File structure is clean (e.g. delete deprecated files, insure filenames are consistent) => done in #395, #398, #408 & others
  • Some Instructor notes are provided => _extras/guide.md
  • Lesson links work as expected => 001ca45 repairs 1 broken link

When all checkboxes above are completed, this lesson will be added to the 18 June lesson release. Please leave a comment on carpentries/lesson-infrastructure#26 or contact Erin Becker with questions (ebecker@carpentries.org).

@diyadas

This comment has been minimized.

Copy link
Collaborator

commented Apr 17, 2019

We've discussed and we'd like to be included in the June lesson release. Will work through the checklist.

@katrinleinweber

This comment has been minimized.

Copy link
Collaborator

commented Apr 18, 2019

I also ran make lesson-check-all, removed most warnings (see below) and updated to the current style (#416). We should definitely merge #403, but the other PRs are optional IMHO.

katrinleinweber added a commit that referenced this issue Apr 18, 2019

Fix most `make lesson-check-all` warnings (see #415)
Except where "too long" lines are only a few characters over MAX_LINE_LEN.

@katrinleinweber katrinleinweber referenced this issue Apr 18, 2019

Open

Prepare June 2019 Lesson Release #418

1 of 3 tasks complete
@katrinleinweber

This comment has been minimized.

Copy link
Collaborator

commented Apr 24, 2019

Regarding "File structure is clean": Can we remove the whole bin/boilerplate folder?

@fmichonneau

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2019

it's not needed by the template. Depending on the number of lessons that will be involved in the release, I'm planning to migrate some/all to using remote themes. With this approach, none of the template files would be part of the repository anymore and updates to the template will happen with every push.

@katrinleinweber

This comment has been minimized.

Copy link
Collaborator

commented Apr 25, 2019

Sounds good! #418 will remove those files for now and in case any later merge conflicts appear because of that, I take responsibility to for resolving them.

@katrinleinweber katrinleinweber referenced this issue Apr 26, 2019

Open

June 2019 Lesson Release checklist #50

7 of 12 tasks complete

@diyadas diyadas added this to the June 2019 Release milestone May 5, 2019

@ErinBecker ErinBecker modified the milestone: June 2019 Release May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.