Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing challenge/exercise solutions and incorrect boxes #424

Open
diyadas opened this issue May 4, 2019 · 5 comments

Comments

Projects
None yet
3 participants
@diyadas
Copy link
Collaborator

commented May 4, 2019

Issue to keep track of missing solutions and incorrect boxes, in preparation for June 2019 lesson release. This tracks only supplementary episodes at the moment.

So far, incorrectly formatted challenges:

Incorrect data directory:

Typos / formatting, while we're at it:

@diyadas diyadas added this to the June 2019 Release milestone May 4, 2019

diyadas added a commit that referenced this issue May 5, 2019

Merge pull request #425 from diyadas/424-formatting
fix the typos/bugs outlined in #424
@diyadas

This comment has been minimized.

Copy link
Collaborator Author

commented May 5, 2019

@katrinleinweber Can you figure out what the aim is of https://github.com/swcarpentry/r-novice-inflammation/blob/master/_episodes_rmd/13-supp-data-structures.Rmd#L156 ?

The best guess I have is that they're 1 dimensional, and that is the definition of a vector. Is that the desired outcome? (Should we remove/rephrase this question?)

@katrinleinweber

This comment has been minimized.

Copy link
Collaborator

commented May 5, 2019

I guess so. Because several more 1D vectors follow below that challenge, we could maybe move it to directly above the Matrix section.

@diyadas

This comment has been minimized.

Copy link
Collaborator Author

commented May 6, 2019

I pushed the others, but I could use some help with the call stack diagram in episode 14.

@diyadas diyadas added the help wanted label May 6, 2019

@katrinleinweber

This comment has been minimized.

Copy link
Collaborator

commented May 7, 2019

About what specifically? I guess we could try to draw our solution idea seperately (e.g. in Google Slides) and compare.

@fmichonneau fmichonneau referenced this issue May 7, 2019

Open

June 2019 Lesson Release checklist #415

10 of 12 tasks complete

@katrinleinweber katrinleinweber referenced this issue May 7, 2019

Open

Improve variable & function names #417

2 of 2 tasks complete

@ErinBecker ErinBecker modified the milestone: June 2019 Release May 9, 2019

@katrinleinweber

This comment has been minimized.

Copy link
Collaborator

commented May 13, 2019

Duplicating an existing SVG and changing the labels in the source code works OK as well (4f5e8aa). However, I'm not sure whether any of 90e50b6?short_path=5ab0efb#diff-ec99aa78325c779963845ff010274632 is similar enough to what we need here.

Which also makes me wonder why it was OK for the previous release to not include a solution to that exercise? I don't think we need to be perfect / address every single issue either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.