Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV file photos are screen shots of Excel files instead of CSV files #434

Closed
sasutils opened this issue Jun 6, 2019 · 1 comment · Fixed by #598
Closed

CSV file photos are screen shots of Excel files instead of CSV files #434

sasutils opened this issue Jun 6, 2019 · 1 comment · Fixed by #598
Labels
enhancement Enhancement to lesson material question Question has an answer; reply if you know it! type:clarification Suggest change for make lesson clearer

Comments

@sasutils
Copy link

sasutils commented Jun 6, 2019

Seems like a great learning tool, but I am curious why do the photos of supposed CSV file outputs have photos of EXCEL spreadsheets instead of the actual CSV files? CSV files are just plain text files. Showing them as if they were EXCEL files will confuse novice programmers into thinking that they are spreadsheets. Plus if you open a CSV file in EXCEL then there is extremely large probability that EXCEL will not properly display the content.

@katrinleinweber
Copy link
Contributor

Hello @sasutils & thanks for making these points :-)

I'm not sure why the csv...png files in the fig folder are the way they are. I followed the git blame trail a few steps into the past, but found no good explanation. Maybe @jeremycg remembers?

Please feel free to send a PR with better screenshots. Maybe in one of the Carpentries-suggested editors or even as a textbox-represenation of the shown .csv files.

Thank you!

@katrinleinweber katrinleinweber added enhancement Enhancement to lesson material question Question has an answer; reply if you know it! type:clarification Suggest change for make lesson clearer labels Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to lesson material question Question has an answer; reply if you know it! type:clarification Suggest change for make lesson clearer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants