Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exercise timing missing for analyzing patient data #519

Open
worcjamessmith opened this issue May 19, 2021 · 8 comments · May be fixed by #619
Open

Exercise timing missing for analyzing patient data #519

worcjamessmith opened this issue May 19, 2021 · 8 comments · May be fixed by #619

Comments

@worcjamessmith
Copy link

The first episode in the programming with R lesson (http://swcarpentry.github.io/r-novice-inflammation/01-starting-with-data/index.html) states that the time for exercises is 0 minutes. However, there are several exercises that I expect would take about 10-15 minutes to complete. Should the exercise timing be updated?

@HaoZeke
Copy link
Member

HaoZeke commented May 20, 2021

Sure, that's a great catch, thanks for bringing it up! Would you be willing to open a PR for the same?

@worcjamessmith
Copy link
Author

Yes, do those timings seem reasonable to you? I.e. 10-15 mins. I haven't actually taught this episode so unsure how long it takes in real life.

@HaoZeke
Copy link
Member

HaoZeke commented May 28, 2021

Yup, I've personally never spent longer than ten minutes but 10-15 sounds perfect. :)

@worcjamessmith
Copy link
Author

I went to open a PR and noticed that exercise time is also missing from other episodes e.g. http://swcarpentry.github.io/r-novice-inflammation/02-func-R/index.html. It might be worth someone going through all the lessons to check, but I didn't yet have time.

Also, changing these will require updating the home page (http://swcarpentry.github.io/r-novice-inflammation/) to update the timings, but I wasn't able to work out how to do this or whether it is done automatically.

@ubdbra001
Copy link

I noticed the same thing, It looks like every episode in the lesson has 0 mins for exercises.
Happy to open a pull request for all, just want to check the timings seem sensible:

  1. Analyzing patient data: 10-15 mins as @worcjamessmith suggests
  2. Creating functions: 10 mins
  3. Analyzing multiple data sets: 10 mins
  4. Making choices: 10-15 mins
  5. Command-line programs: 5 mins
  6. Best Practices for Writing R Code: 5 mins
  7. Dynamic Reports with knitr: 5 mins
  8. Making Packages in R: 3 mins
  9. Introduction to RStudio: 0 mins
  10. Addressing Data: 7 mins
  11. Reading and Writing CSV Files: 5 mins
  12. Understanding Factors: 5 mins
  13. Data Types and Structures: 7-10 mins
  14. The Call Stack: 2-3 mins
  15. Loops in R: 0 mins

I'd also echo the question about whether the timings on the main page are updated manulally or automatically for this.

@HaoZeke
Copy link
Member

HaoZeke commented Jul 6, 2021

Hi @ubdbra001. Thanks for going over these, the timings look great. I can't recall at the moment if they are updated or not, we can deal with that in a separate PR. Please go ahead with the timings from lesson 2 onwards. @worcjamessmith It would be good to have a PR relating to the first lesson :)

@ubdbra001
Copy link

Great will do!

@Bisaloo
Copy link
Member

Bisaloo commented Dec 30, 2023

Hi @worcjamessmith & @ubdbra001, thanks again for catching this and offering to fix it.

Are you still interested and available to submit pull requests for this?

We're always happy to let people contribute directly but if it doesn't work for you, I can integrate the changes myself and mark you as co-authors of the changes.

Bisaloo added a commit that referenced this issue Apr 7, 2024
Fix #519

Co-authored-by: worcjamessmith <worcjamessmith@users.noreply.github.com>
Co-authored-by: Dan Brady <ubdbra001@users.noreply.github.com>
@Bisaloo Bisaloo linked a pull request Apr 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants