Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 13-supp-data-structures.Rmd #428

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@captainalan
Copy link

commented May 5, 2019

whoops; spell check wasn't on---caught a couple typos I made

My contribution for Issue #423 馃槂

Update 13-supp-data-structures.Rmd
whoops; spell check wasn't on---caught a couple typos I made
@diyadas

This comment has been minimized.

Copy link
Collaborator

commented May 6, 2019

Thanks @captainalan ! Would you mind wrapping the extra-long lines, to match the style for the rest of the lesson?

I'll leave it to @katrinleinweber to do the final review, content-wise (it looks good to me, but she's been following the issue from the start).

Update 13-supp-data-structures.Rmd
wrapping some long lines
@captainalan

This comment has been minimized.

Copy link
Author

commented May 6, 2019

@diyadas I broke up some long lines

@diyadas diyadas requested a review from katrinleinweber May 6, 2019

@@ -260,23 +267,26 @@ nchar("Software Carpentry")

In R matrices are an extension of the numeric or character vectors. They are not
a separate type of object but simply an atomic vector with dimensions; the
number of rows and columns.
number of rows and columns. As with atomic vectors, the elements of a matrix must
be of the same data type.

This comment has been minimized.

Copy link
@katrinleinweber

katrinleinweber May 7, 2019

Collaborator

Since we are adding content here anyway, how about turning it into a challenge? Like "Which data types can a matrix contain?" => A solution would be "Any, as long as each element is of the same type.", right?

This comment has been minimized.

Copy link
@katrinleinweber

katrinleinweber May 13, 2019

Collaborator

@captainalan: What do you think about this as a {: .challenge} block?

This comment has been minimized.

Copy link
@captainalan

captainalan May 14, 2019

Author

A challenge block looks good here; it's a step or two of reasoning from the info presented in this lesson

@katrinleinweber
Copy link
Collaborator

left a comment

The content changes are a bit more extensive than I expected after reading #423, but they seem OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.