Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing challenge solutions for episodes 5, 6, 8 #431

Open
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@diyadas
Copy link
Collaborator

commented May 15, 2019

See #427 parts 7,8,9,10,11

@diyadas

This comment has been minimized.

Copy link
Collaborator Author

commented May 15, 2019

Oops, meant to make this a draft, please don't merge yet. All fixed.

@diyadas diyadas changed the title add missing challenge solution for episode 6 add missing challenge solutions for episodes 5, 6, 8 May 15, 2019

@diyadas diyadas requested a review from katrinleinweber May 16, 2019

@diyadas

This comment has been minimized.

Copy link
Collaborator Author

commented May 16, 2019

@katrinleinweber this fills in the rest of #427 , that you hadn't covered with #418 . I think we can close #427 once these two PRs are merged.

I'm ok with merging both as they are. Maybe we should merge #418 first, and then I'll merge master back in to my branch and resolve any conflicts before merging this PR, if this looks alright to you. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.