Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update styles to gh-pages:6d015fe #437

Open
wants to merge 23 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@katrinleinweber
Copy link
Contributor

commented Jun 21, 2019

Closes #436. Due to b50bada in #418, I resolved the conflicts in some boilerplate files by keeping them deleted from this repo.

To do

make serve locally & review visually:

  • aoi
  • 05-cmdline

katrinleinweber and others added some commits Apr 18, 2019

use ndash as separator
display it only if both `page.title` and `site.title` are defined.
aio.md: multiple improvements
Pull Request: carpentries/styles#406

* change all-in-one file to have the same 'depth' as episode files

* move the core script of aio.md into _includes/aio-script.md

* include comment to inform maintainers to not edit the file

* move aio.md to the root of styles repository
@katrinleinweber

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2019

Thanks for reporting this, @timotheenivalis and thanks for providing the fix @fmichonneau :-) Solves for the main issues, but I wonder still about the Output:

image

```{r echo=FALSE, engine='bash'}
cat session-info.R
```

It arguably is output, just of cat. If we want to clarify that as well, maybe removing all the echo=FALSE would make the rendered sites more logical?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.