Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output of `tree` command without introducing it to students. #1062

Closed
joasilva opened this issue Nov 18, 2019 · 5 comments
Closed

Output of `tree` command without introducing it to students. #1062

joasilva opened this issue Nov 18, 2019 · 5 comments

Comments

@joasilva
Copy link

@joasilva joasilva commented Nov 18, 2019

Hi, please check lesson 3

Under "More on Wildcards", a few examples of tree output appear, without tree having been introduced to students so far.

I suggest that tree is succinctly introduced at this point.

Cheers,
João

@gcapes

This comment has been minimized.

Copy link
Contributor

@gcapes gcapes commented Nov 20, 2019

I would hope that this representation would be fairly self-explanatory at this point in the lesson, having already encountered some file system diagrams, but would be happy to review a PR which addresses this concern.

@T0T4R4

This comment has been minimized.

Copy link

@T0T4R4 T0T4R4 commented Nov 27, 2019

Unfortunately, looks like tree is only a Linux thing. Not available on Mac unless you install it with brew.
I find it quite annoying that some part of the tutorial refers to Mac environment, while others to Linux environment. It should be consistent, targeting a unique environment, which in my opinion should be Linux.

@gcapes

This comment has been minimized.

Copy link
Contributor

@gcapes gcapes commented Nov 27, 2019

Ok so how difficult to interpret do we think the output from tree is?

@lkov0

This comment has been minimized.

Copy link

@lkov0 lkov0 commented Dec 9, 2019

In my opinion, since the tree command is not specifically invoked in the lesson and is only used to represent the directory structure, the tree output will not be confusing to learners. Most people who have navigated a filesystem on a GUI are probably familiar with what the diagram represents. I think it's fine how it is and instructors should be able to gauge their audience to determine if further explanation is needed.
However, It could potentially be made clearer by changing: "Sam has a directory containing calibration data, datasets, and descriptions of the datasets:" to "Sam has a directory containing calibration data, datasets, and descriptions of the datasets. The directory structure looks like this:" but like I said, it seems clear enough for most learners the way it is.

@gcapes

This comment has been minimized.

Copy link
Contributor

@gcapes gcapes commented Dec 9, 2019

I'm happy enough that this depiction is fairly self-explanatory. If someone thinks it needs an improvement to the wording as suggested above, I'll review a PR, but I'm closing this issue for no.w

@gcapes gcapes closed this Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.