Skip to content

/ shell-novice

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading diagram in 05-loop.md #502

Open
jarrah42 opened this issue Jan 25, 2017 · 1 comment
Open

Misleading diagram in 05-loop.md #502

jarrah42 opened this issue Jan 25, 2017 · 1 comment

Comments

@jarrah42
Copy link
Contributor

@jarrah42 jarrah42 commented Jan 25, 2017

The diagram on line 251 of _episodes/05-loop.md describes what happens when the loop body is "echo cp $filename original-$filename". However, the commands shown in the text before and after the diagram does not use the "echo" command, but use "cp" directly. It's confusing for the student because the diagram doesn't match the text.
@shwina
Copy link
Member

@shwina shwina commented Jan 30, 2017

Thanks @jarrah42. PRs welcome on this one.
jarrah42 added a commit to jarrah42/shell-novice that referenced this issue Jan 31, 2017
@jarrah42
Additional text to explain diagram. Addresses issue swcarpentry#502.
4e00d77
gdevenyi added a commit that referenced this issue Feb 6, 2017
@gdevenyi
Merge pull request #506 from jarrah42/jarrah42-patch-1
Loading status checks…
fa0b795 
Additional text to explain diagram. Addresses issue #502.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@shwina @jarrah42