New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move challenges into the episode instead of leaving them at the end #637

Open
mfoos opened this Issue Oct 15, 2017 · 11 comments

Comments

Projects
None yet
5 participants
@mfoos

mfoos commented Oct 15, 2017

I'm preparing to teach this for the first time, and I keep "coming up with great ideas for a challenge" only to find that they're clumped at the end (that I've done this more than once is shame on me ;) of course). I don't know if this is deliberately following a different model of teach-test or if it's the result of a migrations?

The challenges already there are smart, and appear tailored to certain concepts, it would be nice to move them alongside, instead of every instructor doing it themselves independently

@gdevenyi

This comment has been minimized.

Contributor

gdevenyi commented Oct 16, 2017

Hi @mfoos I'm not sure what you're referring to, can you please provide some more detail? Thanks!

@mfoos

This comment has been minimized.

mfoos commented Oct 16, 2017

Of course :)

So for example, in this episode: http://swcarpentry.github.io/shell-novice/04-pipefilter/, except for "Using Wildcards", all of the challenges are at the end of the episode. But the "Pipe Construction" challenge is 7th of 11 in a set of challenges that come immediately one after another, whereas it would make a great "idea reinforcer" if it came immediately after "$ wc -l *.pdb | sort -n | head -n 1" where we first see the full power of pipes revealed.

@gdevenyi

This comment has been minimized.

Contributor

gdevenyi commented Oct 17, 2017

Ah ha, I see. That's indeed silly.

This is definitely a great enhancement and reasonably newcomer friendly.

If you want to tackle any of these, please do them one-at-a-time rather than all-at-once.

Thanks!

@mfoos

This comment has been minimized.

mfoos commented Oct 17, 2017

Great thinking! I will probably undertake a few soon, I have a few weeks of chaos I have to get through first :)

@shwina

This comment has been minimized.

Member

shwina commented Oct 17, 2017

That's actually how the challenges were laid out in previous versions of the lesson (i.e., interspersed with the text).

I think the rationale for re-organizing was that the lesson is broken up into small enough teachable chunks (episodes) so that they can be taught in a continuous live coding session, after which learners would work on challenges to reinforce what they have learned.

I agree this is a problem because each "episode" (in the shell-novice lesson, at least) takes far too much time to cover.

@yeemey yeemey referenced this issue Oct 20, 2017

Merged

ENH: Move challenges into episode (Issue #637) #642

3 of 3 tasks complete
@ErinBecker

This comment has been minimized.

Collaborator

ErinBecker commented Oct 31, 2017

Thanks for raising this issue @mfoos! I concur with the discussion here. This has also been discussed previously here and here.

The Lesson Infrastructure Subcommittee is meeting on the 16th and I will be bringing this up there. Certainly the individual lessons (such as shell) can move forward on this without waiting for a decision to be made at the lesson infrastructure level, but last time this came up there was conversation that a decision at that level would help motivate these changes at the individual lesson levels.

For comparison, Data Carpentry lessons and the Carpentry instructor training curriculum are already organized with interspersed exercises and this seems to work really well.

shwina added a commit that referenced this issue Nov 1, 2017

Merge pull request #642 from yeemey/issue-637
ENH: Move challenges into episode (Issue #637)
@ErinBecker

This comment has been minimized.

Collaborator

ErinBecker commented Nov 27, 2017

As an update, the Lesson Infrastructure Subcommittee met on Nov 16 and concurred with the sentiment on this thread that it makes sense to move the exercises from the end of each episode into the relevant parts of the episode so that instructors know at which points it makes sense to use each exercise. I volunteered to go through the Git, Python, and this lesson to submit PRs for moving each of the exercises. I'll put in separate PRs for each exercise so that they're easier to review. Thanks again for raising this issue @mfoos!

@ErinBecker

This comment has been minimized.

Collaborator

ErinBecker commented Nov 27, 2017

I believe this issue can be closed after reviewing/merging the following PRs. Please let me know if I've missed anything that should be moved.

#662
#663
#664
#665
#666
#667
#668
#669
#670
#671
#672

@gdevenyi

This comment has been minimized.

Contributor

gdevenyi commented Jan 4, 2018

Hi @ErinBecker sorry for the large delay.

Did you do a local build of these? If so I'll hit go on all of them :)

@ErinBecker

This comment has been minimized.

Collaborator

ErinBecker commented Jan 5, 2018

@gdevenyi - I did do a local build and everything looked good on my end.

@gdevenyi

This comment has been minimized.

Contributor

gdevenyi commented Jan 8, 2018

Merged except for two that need a slight bit of rebasing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment