Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Pipes and Filters" episode, `Sort` example. #748

Open
kekoziar opened this issue Mar 26, 2018 · 2 comments
Open

"Pipes and Filters" episode, `Sort` example. #748

kekoziar opened this issue Mar 26, 2018 · 2 comments

Comments

@kekoziar
Copy link
Contributor

@kekoziar kekoziar commented Mar 26, 2018

In the "Pipes and Filters" episode, the example

What Does sort -n Do?

is incomplete and does not include command lines. Also, it is positioned before sort is actually covered in the lesson, bisecting the curriculum.

@colinmorris
Copy link
Contributor

@colinmorris colinmorris commented Mar 27, 2018

I agree that this could be improved.

I wonder if the "What does sort -n do?" content should just be integrated into the main body of the lesson. As an exercise, it seems pretty anemic.

@samhalsey
Copy link

@samhalsey samhalsey commented Mar 27, 2018

I just created a pull request to move "What does sort -n do?" up a level into the main body. Also I don't think that this part is incomplete as its not really an example (hence the reason I removed it from looking like an example) but it kind of like an active learning exercise where the student look to see what is happening to figure out what the flag -n means. At the end, there is then the question before going into more detail about what sort does with working examples of nelles' data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.