Flow chart is not entirely representing for loop #408

Open
wants to merge 1 commit into
from

Projects

None yet

3 participants

@lexnederbragt
Member

I find the flow chart part of the shell_script_for_loop_flow_chart in 04-loop not really representing a for-loop in that it says $filename found --> No --> End? If $filename is not found, the shell will throw an error.

This PR changes the text to Next $filename? in the hope that would work better.

(I don't know how to recreate the vsdfile)

@lexnederbragt lexnederbragt Flow chart is not entirely representing for loop
I find the flow chart part of the [shell_script_for_loop_flow_chart](https://github.com/swcarpentry/shell-novice/blob/gh-pages/fig/shell_script_for_loop_flow_chart.svg) in 04-loop not really representing a for-loop in that it says `$filename found --> No` --> `End`? If `$filename` is not found, the shell will throw an error.

This PR changes the text to `Next $filename?` in the hope that would work better.
b5ab492
@shwina
Member
shwina commented Jun 21, 2016 edited
  1. As @lexnederbragt mentions, $filename found? isn't the right question to ask. Maybe the better question is "Are we done with all files?". What say?
  2. I'm not entirely convinced about the stdin. Shouldn't stdin be input-1.dat original-input-1.dat, etc.?
  3. Finally, the chart is created using Microsoft Visio. At the moment, we've got a copy of both the .vsd, and the corresponding .svg. This is a PR that updates only the .svg, which will make the .svg fall out of sync.

@fgacenga - copying you as the original contributor. Any suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment