New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 07-find.md #491

Open
wants to merge 1 commit into
base: gh-pages
from

Conversation

Projects
None yet
4 participants
@petersm3
Contributor

petersm3 commented Dec 6, 2016

matthew@cgrb.oregonstate.edu
Instructor Training: Checkout Procedure
Part 1: Submit a Small Contribution to One of Our Lessons

Possible lesson addition for issue: Add example of "grep -r" #177

Update 07-find.md
Possible addition for issue:

Add example of "grep -r" #177
@petersm3

This comment has been minimized.

Contributor

petersm3 commented Dec 6, 2016

The example may have too many files and subdirectories; it may be better to split the haiku.txt into 2 or 3 lines per file, with 6 or 4 subdirectories respectively (as opposed to 11).

@petersm3

This comment has been minimized.

Contributor

petersm3 commented Dec 12, 2016

The setup step could be eliminated, i.e., the mkdir/split/mv, and the files pre-staged in shell-novice-data.zip

@shwina

This comment has been minimized.

Member

shwina commented Dec 23, 2016

@petersm3

Yes, I think it would be better to pre-stage the required files/directories in the .zip file. It's not necessary that this example on grep -r use haiku.txt as input.

@petersm3

This comment has been minimized.

Contributor

petersm3 commented Dec 23, 2016

Should I update this commit or create a new commit which adds the assets created by the split of haiku.txt in the data-shell/writing directory along with the updating of the 07-find.md documentation, i.e., grep -r example, to reflect using the pre-staged files?

"It's not necessary that this example on grep -r use haiku.txt as input."

Suggestions as to how a grep -r example could be illustrated in the lesson? (other than using the haiku.txt example)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment