New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

04-pipefilter Wildcard Expressions-solution added content to point 1 … #647

Open
wants to merge 1 commit into
base: gh-pages
from

Conversation

Projects
None yet
2 participants
@paulamool

paulamool commented Oct 25, 2017

Issue #615
This contribution is for instructor training
Edited lesson 04-pipefilter, Wildcard Expressions - Solution, added content to point 1 and 3

@colinmorris

This looks great! Just a couple nitpicks.

Sorry for the wait!

> expression.
>
> 2. The expression that you found and the expression from the lesson match the
> 2. The expressions that you found and the expression from the lesson match the
> same set of files in this example. What is the small difference between the
> outputs?

This comment has been minimized.

@colinmorris

colinmorris Feb 1, 2018

Contributor

As you mentioned in #615, this question is clearly written with the "two ls commands" solution in mind, but for someone who comes up with the single ls solution, this question has no answer. I'd suggest relaxing the wording ("is there any difference" rather than "what is the difference"), or just removing this question, and mentioning the difference in the solution section.

> > or
> >
> > ```
> > $ ls *A.txt *B.txt

This comment has been minimized.

@colinmorris

colinmorris Feb 1, 2018

Contributor

I'd actually suggest putting this solution first, since it's "nicer".

> > 2. The output from the two `ls` commands is separated because there are two commands.
> > 3. You would get an error message for the commands in point 1 when there are no files
> > ending in `A.txt`, or there are no files ending in `B.txt`. While `ls *[AB].txt would
> > not produced an error message, unless all possible expressions are missing.

This comment has been minimized.

@colinmorris

colinmorris Feb 1, 2018

Contributor

unless all possible expressions are missing

This wording feels a little awkward. Maybe "unless no files match" instead? "unless no files end in either A or B"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment