Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Shell lesson, No.7 [Last exercise] - Better to not hard-code the username #696
The last exercise (shell-novice, lesson no.7): "Finding files with different properties"
But not necessarily the workshop attendee would have that user name in his/her PC/Mac. And also, when I downloaded and unzipped the shell-novice-data.zip, none of the files in the uncompressed folder are of user 'ahmed'.
Hence it would be better to catch the username on the fly using the command that has already been introduced in lesson no.2.
Hence instead of this as solution -
I suggest this -
Dear Gabriel, Yes, I noticed the whitespace changes but only after I had submitted the PR. I had used Atom text editor on Mac to make changes to the .md file. Probably the editor did something to the line end characters. Ok I will try to sort this out. Thanks, From: "Gabriel A. Devenyi" <email@example.com> Reply-To: swcarpentry/shell-novice <firstname.lastname@example.org> Date: Tuesday, 30 January 2018 at 21:26 To: swcarpentry/shell-novice <email@example.com> Cc: "Mandal, Amit K" <firstname.lastname@example.org>, Author <email@example.com> Subject: Re: [swcarpentry/shell-novice] Shell lesson, No.7 [Last exercise] - Better to not hard-code the username (#696) This looks okay, but I'd like the command broken out so the user checks their ownership first on a separate line. Also, there's a bunch of whitespace changes, can you clobber those and rebase? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#696 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AYNetM6ELcemXBzISI2Etq3EybAECgFvks5tP4j6gaJpZM4Rymxs>.