Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced the "taster" regex example with one that I think is a #930

Closed
wants to merge 1 commit into from
Closed

Replaced the "taster" regex example with one that I think is a #930

wants to merge 1 commit into from

Conversation

@gjanee
Copy link

@gjanee gjanee commented Mar 8, 2019

Replaced the "taster" regex example with one that I think is a little more realistic.

@gcapes
Copy link
Contributor

@gcapes gcapes commented Mar 11, 2019

Thanks for the PR!

I would support the move to a better motivated example like this. However I have two reservations about this suggestion:

  1. document.txt doesn't exist in data-shell so the example isn't runnable. We could add such a file but we're trying to avoid further bloating the lesson.
  2. The number format is rather US-centric. Perhaps a URL would be a more inclusive example, but again it would require adding to the existing data set.

Thoughts from @swcarpentry/shell-maintainers?

@gdevenyi
Copy link
Contributor

@gdevenyi gdevenyi commented Mar 11, 2019

I have the same concerns as @gcapes. I think we want runnable examples everywhere. Maybe an ISO date?

@gcapes
Copy link
Contributor

@gcapes gcapes commented Jul 29, 2019

Yep, that would work from the data-shell directory:

$ grep -rE '[0-9]{4}-[0-9]{2}-[0-9]{2}' *

data/animal-counts/animals.txt:2012-11-05,deer,5
data/animal-counts/animals.txt:2012-11-05,rabbit,22
data/animal-counts/animals.txt:2012-11-05,raccoon,7
data/animal-counts/animals.txt:2012-11-06,rabbit,19
data/animal-counts/animals.txt:2012-11-06,deer,2
data/animal-counts/animals.txt:2012-11-06,fox,4
data/animal-counts/animals.txt:2012-11-07,rabbit,16
data/animal-counts/animals.txt:2012-11-07,bear,1
data/animals.txt:2012-11-05,deer
data/animals.txt:2012-11-05,rabbit
data/animals.txt:2012-11-05,raccoon
data/animals.txt:2012-11-06,rabbit
data/animals.txt:2012-11-06,deer
data/animals.txt:2012-11-06,fox
data/animals.txt:2012-11-07,rabbit
data/animals.txt:2012-11-07,bear

gcapes added a commit to gcapes/shell-novice that referenced this issue Aug 26, 2020
@deppen8
Copy link
Contributor

@deppen8 deppen8 commented Sep 1, 2021

Closing this because this issue is being addressed in #1134

@deppen8 deppen8 closed this Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants