Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced the "taster" regex example with one that I think is a #930

Open
wants to merge 1 commit into
base: gh-pages
from

Conversation

Projects
None yet
3 participants
@gjanee
Copy link

commented Mar 8, 2019

Replaced the "taster" regex example with one that I think is a little more realistic.

@gcapes

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2019

Thanks for the PR!

I would support the move to a better motivated example like this. However I have two reservations about this suggestion:

  1. document.txt doesn't exist in data-shell so the example isn't runnable. We could add such a file but we're trying not avoid further bloating the lesson.
  2. The number format is rather US-centric. Perhaps a URL would be a more inclusive example, but again it would require adding to the existing data set.

Thoughts from @swcarpentry/shell-maintainers?

@gdevenyi

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2019

I have the same concerns as @gcapes. I think we want runnable examples everywhere. Maybe an ISO date?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.