Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example explanation #973

Open
wants to merge 2 commits into
base: gh-pages
from

Conversation

Projects
None yet
4 participants
@mozeran
Copy link

commented May 21, 2019

Pull request to solve issue 971

Update example explanation
Pull request to solve issue 971 #971
@gdevenyi

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

Thanks, I like the changes, I just have some small adjustment to the language.

@gcapes

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

@gdevenyi
What would those adjustments be?

and then prints the
first three lines of `basilisk.dat`.
pipes the first two lines to the `tail` command,
and then prints the second line of `basilisk.dat`.

This comment has been minimized.

Copy link
@gdevenyi

gdevenyi May 28, 2019

Contributor

"and then" -> "which then"

For the second iteration, `$filename` becomes
`unicorn.dat`. This time, the shell runs `head` on `unicorn.dat`
and prints the first three lines of `unicorn.dat`.
pipes the first two lines to the `tail` command,
and then prints the second line of `unicorn.dat`.

This comment has been minimized.

Copy link
@gdevenyi

gdevenyi May 28, 2019

Contributor

"and then" -> "which then"

This comment has been minimized.

Copy link
@gdevenyi

gdevenyi Jun 18, 2019

Contributor

If we change it to "which then," it's no longer a complete sentence. If you prefer "which then", should it be this (with similar modification for the other one)? "This time, the shell runs head on unicorn.dat and pipes the first two lines to the tail command, which then prints the second line of unicorn.dat."

Sure, I agree.

@gdevenyi

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

Man I'm bad at hitting that "request changes" button....

@mozeran

This comment has been minimized.

Copy link
Author

commented Jun 5, 2019

If we change it to "which then," it's no longer a complete sentence. If you prefer "which then", should it be this (with similar modification for the other one)? "This time, the shell runs head on unicorn.dat and pipes the first two lines to the tail command, which then prints the second line of unicorn.dat."

and then prints the
first three lines of `basilisk.dat`.
pipes the first two lines to the `tail` command,
and then prints the second line of `basilisk.dat`.
For the second iteration, `$filename` becomes
`unicorn.dat`. This time, the shell runs `head` on `unicorn.dat`

This comment has been minimized.

Copy link
@ngranda

ngranda Jun 17, 2019

Suggested change
`unicorn.dat`. This time, the shell runs `head` on `unicorn.dat`
`unicorn.dat`. This time, the shell runs `head` on `unicorn.dat`,
@ngranda
Copy link

left a comment

Changes look good, just a minor suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.