New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absolute link to "/raw/gh-pages" breaks in lesson release #163

Open
twitwi opened this Issue Feb 9, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@twitwi
Contributor

twitwi commented Feb 9, 2017

The index page have the following links

 [survey.db]({{ site.github.repository_url }}/raw/gh-pages/files/survey.db)

This explicitly links to the currently latest version of db file, which can be a good thing (propagate fixes more rapidly) or a not-so-good thing (possible incoherence between the lesson people are reading and the db file they might be downloading).

This semi-absolute link also causes problems (by default) in the releases, as in http://swcarpentry.github.io/swc-releases/2017.02/sql-novice-survey/

I have partial information on this and there might be other reasons for this link, but my recommendation would be to switch to a relative link like "files/survey.db" or "./files/survey.db".

rgaiacs pushed a commit to rgaiacs/swc-sql-novice-survey that referenced this issue May 6, 2017

rgaiacs added a commit to rgaiacs/swc-sql-novice-survey that referenced this issue Apr 17, 2018

Merge pull request swcarpentry#163 from mawds/sortfigs
Output episode figures in correct order

@remram44 remram44 added the type:bug label Jun 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment