New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Field names discussion - teaching moments or just fix? #202

Open
dlstrong opened this Issue Jan 23, 2018 · 1 comment

Comments

Projects
None yet
4 participants
@dlstrong

dlstrong commented Jan 23, 2018

While the SWC SQL lesson has much friendlier field names than the social science one (q4xii anybody?), there are still some oddities in the field names here.

I've been using them as teaching moments -- "remember the spreadsheet sessions section on helpful column names? There are two fields named 'id' in different tables; here's why it would be more helpful to have this field named visit_id and this other one named person_id; here's why 'taken' is not a helpful field name because of the number of ways the desired data input could be misinterpreted, and why something like fkey_visit_id would be more informative both to data contributors and to future researchers looking at the same dataset".

So I'm torn on whether to actually suggest changes to the fields or whether to suggest edits in the text that point out the potential for field name improvements, with some leanings toward the latter.

What does the community think?

@gcapes

This comment has been minimized.

Contributor

gcapes commented Apr 3, 2018

I'm just working through the lesson for the first time and I'm confused by what the taken variable means. I could well have missed it, but I don't think it's ever introduced/explained?
I think either explaining what this heading means, or renaming it to something more self-explanatory would be useful.

rgaiacs added a commit to rgaiacs/swc-sql-novice-survey that referenced this issue Apr 17, 2018

Merge pull request swcarpentry#202 from rgaiacs/gh-pages
Fix CSS to use .language-X class

@fmichonneau fmichonneau added type:bug and removed bug labels Jun 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment