New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meaning of `Survey.quant` values #239

Open
cwant opened this Issue May 7, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@cwant
Contributor

cwant commented May 7, 2018

The Survey table has a field called quant that holds what type of reading was taken. The values in this column are rad, sal, and temp. There is no legend that explains what these mean on the page where the data is introduced (the selecting data chapter). Much later in the course it's mentioned that these mean 'radiation', 'salinity' and 'temperature', but I think it would also be helpful to mention the meaning earlier when the data is presented.

@henrykironde

This comment has been minimized.

Collaborator

henrykironde commented May 7, 2018

Thanks @cwant. If you have some time, could you please let us know where you think that information would be best fit. Additionally, if possible to put in a PR, we would appreciate it. Otherwise we shall look into the issue.

@nathan-hook

This comment has been minimized.

nathan-hook commented May 7, 2018

I also got caught up on what quant was and after a quick google search it is short for Quantitative, which has a meaning of "relating to, measuring, or measured by the quantity of something rather than its quality."

Which I don't feel totally fits what the column is actually trying to describe, perhaps a better word would be measurement or category? Just a thought.

But, it could also be a representation of the original data and wanting to stay 'true' to the way that the records were originally recorded.

@remram44

This comment has been minimized.

Collaborator

remram44 commented May 7, 2018

I assumed it was short for "quantity"

@cwant

This comment has been minimized.

Contributor

cwant commented May 7, 2018

Yeah, I also assumed quantity, but that could have been more clear, and it would probably be a good idea to include that information also.

Regarding the 'original data', I did a bit of googling, and it appears that all of the people, places, etc. come from an H. P. Lovecraft horror story:

https://en.wikipedia.org/wiki/At_the_Mountains_of_Madness

So, I'm guessing keeping the fidelity of the original data isn't an issue 😃

I can submit a PR, but I'll wait a bit in case this might be a good task for somebody doing 'instructor checkout'.

fmichonneau pushed a commit that referenced this issue Jun 19, 2018

Merge pull request #239 from rgaiacs/237
Fix Copyright information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment