Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Completing ident -> id change #156
referenced this pull request
Nov 27, 2016
@acabunoc, I never recall seeing any (although I now see #130), but when I downloaded the data and ran through the material myself, I found it constantly referencing the wrong file. I could see various commits in the history changing some refs.
I think I've caught the remaining references, but not 100% sure.
@acabunoc @fmichonneau @mckays630 @jangari If you've taught the SwC SQL Lesson recently, have you had install issues? See issues I've submitted (and other folks related tickets). If i do the SwC software installs as student, the command
Also, I am confused when reading the lesson now - should it be survey.db (which I can get to work after cloning the git repository), or survey.sqlite which I cannot get to work at all?
Hi @debpaul, I haven't taught it yet for a SC workshop, but I ran through the material at length and also ran a train-the-trainer for my colleagues, as we'll be adding the course to our training offering.
We run a slightly different setup with virtual machines with all the software and data preinstalled, so I made sure the SQL course has everything in the right location.
I suspect the reason that using survey.db works for you and not survey.sqlite, is that the file has not yet been renamed to survey.sqlite. A commit (#156) in this pull request fixes that.
I think the other issues you refer to are down to the same inconsistency. I taught my colleagues using VM images that include the survey.sqlite file, and from my own repository from which I'm making this pull request. So I'm confident that - while it may not fix all issues to do with installation - it'll at least be more consistent across systems.
I should add that I'll be teaching this course at a SC at Deakin in December (http://intersectaustralia.github.io/2016-12-12-Deakin) and if this pull request is merged by then, I will thoroughly test beforehand. If there are remaining issues I will probably base the workshop on my fork.
pushed a commit
this pull request
May 6, 2017