New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few small fixes + new SELECT challenge #159

Open
wants to merge 3 commits into
base: gh-pages
from

Conversation

Projects
None yet
4 participants
@ncarchedi

ncarchedi commented Nov 30, 2016

Hi, I hope these changes are helpful. I'd also like to go through and add solutions to many of the existing challenges (+ the one I added with this PR). See #158

ncarchedi added some commits Nov 26, 2016

merge updates into branch
Merge remote-tracking branch 'upstream/gh-pages' into various-updates

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@@ -89,18 +89,18 @@ Next,
create the database that will be used:

~~~
$ sqlite3 survey.sqlite .read bin/create-db.sql
$ sqlite3 survey.db .read bin/create-db.sql

This comment has been minimized.

@acabunoc

acabunoc Dec 10, 2016

Member

We'll be moving to calling this file survey.sqlite everywhere soon (see #156) -- can you remove these changes?

This comment has been minimized.

@ncarchedi

ncarchedi Dec 14, 2016

@acabunoc Sorry for the delay. Sure thing. Do you want me to change survey.db to survey.sqlite everywhere else in the lesson while I'm at it? It's quite a few places:

screenshot 2016-12-14 12 32 53

This comment has been minimized.

@jangari

jangari Dec 20, 2016

You can, or my PR (#156) fixes these references as well.

@acabunoc

This comment has been minimized.

Member

acabunoc commented Dec 10, 2016

Just the one naming change, then I think this is good to merge in!

Thank you @ncarchedi! Great work 🚀

rgaiacs pushed a commit to rgaiacs/swc-sql-novice-survey that referenced this pull request May 6, 2017

rgaiacs added a commit to rgaiacs/swc-sql-novice-survey that referenced this pull request Apr 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment