rec modification to use newsurvey database so users can run sql commands #193
Conversation
rgaiacs
added a commit
to rgaiacs/swc-sql-novice-survey
that referenced
this pull request
Apr 17, 2018
Fix bin/lesson_initialize.py
|
@GRG2 Thanks for this contribution |
|
Agree, a note about this is welcome! "Selecting Data exercise" should be "Selecting Data episode" though. Would also be nice if language could be improved a bit overall (e.g. "begin with the new database" → "begin with a new database", "currently within the SQLite interactive session" → "currently using SQLite", "Start the SQLite3" → "Start SQLite3", etc.), but it's understandable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The changes recommended to this exercise would allow users to run the SQL commands. With the current lesson, the previous survey.db does not allow this due to conflict with existing tables. It's fairly straightforward to start with an empty db and run the commands as edited in this file. I did not see if the markup was 100% correct, followed previous version as template.